Commit146d85a

committed

ConvertDoNotAccessAClosedFile to the new dataflow library

1 parentf265690 commit146d85aCopy full SHA for 146d85a

File tree

-3

lines changed

cpp/common/src/codingstandards/cpp/rules/donotaccessaclosedfile
- DoNotAccessAClosedFile.qll

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`import cpp`
`7`	`7`	`import codingstandards.cpp.Customizations`
`8`	`8`	`import codingstandards.cpp.Exclusions`
`9`		`-import semmle.code.cpp.dataflow.DataFlow`
	`9`	`+import semmle.code.cpp.dataflow.new.DataFlow`
`10`	`10`	`import codingstandards.cpp.standardlibrary.FileAccess`
`11`	`11`	`import semmle.code.cpp.controlflow.SubBasicBlocks`
`12`	`12`
`@@ -40,9 +40,10 @@ SubBasicBlock followsFileClose(SubBasicBlock source, Expr closedFile) {`
`40`	`40`
`41`	`41`	// the argument of a call to function `fclose(FILE*)` is subsequently accessed
`42`	`42`	`predicateclosedFileAccess(ExprclosedFile,ExprfileAccess){`
`43`		`-exists(DataFlow::DefinitionByReferenceNodedef\|`
	`43`	`+exists(DataFlow::DefinitionByReferenceNodedef, DataFlow::Nodeva\|`
	`44`	`+va.asIndirectExpr()=fileAccess.(VariableAccess)and`
`44`	`45`	`def.asDefiningArgument()=closedFileand`
`45`		`- DataFlow::localFlow(def,DataFlow::exprNode(fileAccess.(VariableAccess)))`
	`46`	`+ DataFlow::localFlow(def,va)`
`46`	`47`	`)`
`47`	`48`	`}`
`48`	`49`

Comments

(0)