Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Compute PR diff-ranges during init#3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
kaspersv wants to merge4 commits intomain
base:main
Choose a base branch
Loading
fromkaspersv/pr-diff-ranges-in-init

Conversation

@kaspersv
Copy link
Contributor

When diff-informed analysis is performed, PR diff-ranges are currently computed by theanalyze action. This PR moves computation and persistence of PR diff-ranges to theinit action instead. The motivation for moving the PR diff-range computation to theinit action is to make it available for overlay analysis and include all files within the PR diff-range in theoverlay-changes.json file generated for overlay analysis during theinit action.

The commits have been cherry-picked from#3192 and modified.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Advanced setup - Impacts users who have custom workflows.
  • Default setup - Impacts users who use default setup.
  • Code Scanning - Impacts Code Scanning (i.e.analysis-kinds: code-scanning).
  • Code Quality - Impacts Code Quality (i.e.analysis-kinds: code-quality).
  • GHES - Impacts GitHub Enterprise Server.

How did/will you validate this change?

  • Test repository - This change will be tested on a test repository before merging.
  • Unit tests - I am depending on unit test coverage (i.e. tests in.test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Feature flags - All new or changed code paths can be fully disabled with corresponding feature flags.
  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding achangelog entry for this change.
  • Confirm thereadme and docs have been updated if necessary.

We don't use them yet and will re-save them during analysis.
@github-actionsgithub-actionsbot added size/SShould be easy to review size/MShould be of average difficulty to review and removed size/SShould be easy to review labelsOct 28, 2025
@kaspersvkaspersvforce-pushed thekaspersv/pr-diff-ranges-in-init branch from1f567a0 tod321539CompareOctober 28, 2025 09:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotAwaiting requested review from CopilotCopilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/MShould be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaspersv@alexet

[8]ページ先頭

©2009-2025 Movatter.jp