- Notifications
You must be signed in to change notification settings - Fork13
Adds filter to target specific cluster connections#95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sdseaton commentedApr 4, 2025
- Adds attribute to Cluster model to indicate if cluster is active.
- Adds filter option to KustoSchemaHandler Tasks to allow targeting specific cluster connections if a list of included connections is provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds filtering functionality to target specific cluster connections by introducing a new boolean attribute in the Cluster model and a filtering method in the KustoSchemaHandler.
- Adds an IsActive property to the Cluster model to denote active clusters.
- Implements the FilterClusters method in KustoSchemaHandler to filter connections based on activity status or an explicit list of included connections.
- Updates methods GenerateDiffMarkdown, Import, and Apply to utilize the new filtering logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| KustoSchemaTools/Model/Cluster.cs | Introduces a new property IsActive to mark clusters as active. |
| KustoSchemaTools/KustoSchemaHandler.cs | Adds FilterClusters method and updates existing methods to filter connections. |
Comments suppressed due to low confidence (1)
KustoSchemaTools/KustoSchemaHandler.cs:28
- Consider adding test cases to verify the behavior of FilterClusters with various inputs, including cases with a null or empty includedConnections list and with explicit connection names.
public Clusters FilterClusters(Clusters clusters, List<string>? includedConnections)Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon.Learn more