- Notifications
You must be signed in to change notification settings - Fork13
Do not fail if single cluster apply fails#130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR enhances the fault tolerance of the cluster orchestration process by adding error handling to prevent a single cluster failure from stopping the entire multi-cluster apply operation. When one cluster fails, the system now logs the error and continues processing remaining clusters, ensuring maximum coverage of change deployments.
Key Changes:
- Wrapped the cluster apply logic in a try-catch block to isolate failures
- Added CreateFailedClusterResult helper method to generate standardized error results
- Ensured all results (both successful and failed) are included in the return value
💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
67847e8 intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.