Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Do not fail if single cluster apply fails#130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sdseaton merged 1 commit intomainfrombugfix/cluster_apply
Dec 17, 2025

Conversation

@sdseaton
Copy link
Contributor

No description provided.

CopilotAI review requested due to automatic review settingsDecember 17, 2025 16:24
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR enhances the fault tolerance of the cluster orchestration process by adding error handling to prevent a single cluster failure from stopping the entire multi-cluster apply operation. When one cluster fails, the system now logs the error and continues processing remaining clusters, ensuring maximum coverage of change deployments.

Key Changes:

  • Wrapped the cluster apply logic in a try-catch block to isolate failures
  • Added CreateFailedClusterResult helper method to generate standardized error results
  • Ensured all results (both successful and failed) are included in the return value

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

@sdseatonsdseaton merged commit67847e8 intomainDec 17, 2025
11 checks passed
@sdseatonsdseaton deleted the bugfix/cluster_apply branchDecember 17, 2025 16:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@ashleyvanspashleyvanspashleyvansp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdseaton@ashleyvansp

[8]ページ先頭

©2009-2025 Movatter.jp