Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(deps): update Cocoa SDK to v9#5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
antonis wants to merge35 commits intomain
base:main
Choose a base branch
Loading
fromcocoa-v9
Draft

chore(deps): update Cocoa SDK to v9#5356

antonis wants to merge35 commits intomainfromcocoa-v9

Conversation

@antonis
Copy link
Contributor

@antonisantonis commentedNov 11, 2025•
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Breaking changes:

SubPRs:

💡 Motivation and Context

See#5273

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII ifsendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis
Copy link
ContributorAuthor

Marking asBlocked while the Cocoa v9 is in Alpha

itaybreand others added3 commitsNovember 11, 2025 16:38
* fix: Fixes SentryScreenFrames use after being converted to Swift* Fix build---------Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift* Fix build* Use non-experimental enableLogs* bump target* remove enable tracing* Update enableLogs tests---------Co-authored-by: Itay Brenner <itay.brenner@sentry.io>Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift* Fix build* Use non-experimental enableLogs* bump target* remove enable tracing* Update enableLogs tests* chore: Fix RNSentry after SentryFramesTracker conversion to swift* Run linter* Remove unused debug image provider imports* Remove imports* chore: Remove deprecated user property* chore: Remove use of deprecate integrations API (#5304)* Remove use of integrations in tests* chore: Remove use of deprecated prop (#5322)* ref: Move options to wrapper---------Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>Co-authored-by: Denis Andrasec <denrase@gmail.com>Co-authored-by: Noah Martin <noahm444@gmail.com>
@antonisantonis added the ready-to-mergeTriggers the full CI test suite labelNov 11, 2025
@antonis
Copy link
ContributorAuthor

Adding theready-to-merge label to trigger all tests but it's not really ready to merge 😅

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 11, 2025•
edited
Loading

Android (new) Performance metrics 🚀

 PlainWith SentryDiff
Startup time369.06 ms386.56 ms17.50 ms
Size43.94 MiB48.91 MiB4.97 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
ad27f6e+dirty484.67 ms532.79 ms48.12 ms
f081f58+dirty468.47 ms492.64 ms24.17 ms
294387d+dirty359.44 ms393.40 ms33.97 ms
c08359e+dirty406.04 ms428.87 ms22.83 ms
e07935d+dirty380.10 ms377.48 ms-2.62 ms
9b50d32+dirty429.59 ms423.89 ms-5.70 ms
3099014+dirty344.58 ms404.21 ms59.63 ms
eec00c2+dirty367.00 ms392.12 ms25.12 ms
a31630c+dirty359.89 ms416.90 ms57.00 ms
e335046+dirty375.75 ms392.85 ms17.10 ms

App size

RevisionPlainWith SentryDiff
ad27f6e+dirty43.94 MiB48.90 MiB4.96 MiB
f081f58+dirty43.94 MiB48.82 MiB4.88 MiB
294387d+dirty43.94 MiB48.87 MiB4.93 MiB
c08359e+dirty7.15 MiB8.42 MiB1.27 MiB
e07935d+dirty43.94 MiB48.82 MiB4.88 MiB
9b50d32+dirty43.94 MiB48.87 MiB4.93 MiB
3099014+dirty7.15 MiB8.43 MiB1.27 MiB
eec00c2+dirty43.94 MiB48.87 MiB4.93 MiB
a31630c+dirty7.15 MiB8.41 MiB1.26 MiB
e335046+dirty43.94 MiB48.87 MiB4.93 MiB

Previous results on branch: cocoa-v9

Startup times

RevisionPlainWith SentryDiff
0816bdc+dirty576.86 ms619.67 ms42.81 ms
326e1a7+dirty425.27 ms425.81 ms0.54 ms
9aa9f9b+dirty597.51 ms634.22 ms36.71 ms

App size

RevisionPlainWith SentryDiff
0816bdc+dirty43.94 MiB48.90 MiB4.96 MiB
326e1a7+dirty43.94 MiB48.90 MiB4.96 MiB
9aa9f9b+dirty43.94 MiB48.90 MiB4.96 MiB

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 11, 2025•
edited
Loading

Android (legacy) Performance metrics 🚀

 PlainWith SentryDiff
Startup time405.30 ms422.77 ms17.46 ms
Size43.75 MiB48.08 MiB4.33 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
083f560+dirty358.21 ms382.00 ms23.79 ms
ad27f6e+dirty471.44 ms516.23 ms44.79 ms
f081f58+dirty443.98 ms480.26 ms36.28 ms
d916aa3425.37 ms427.02 ms1.65 ms
294387d+dirty424.30 ms465.40 ms41.10 ms
90afdd3+dirty375.94 ms377.52 ms1.58 ms
e07935d+dirty448.82 ms489.10 ms40.29 ms
9b50d32+dirty455.51 ms466.56 ms11.05 ms
eec00c2+dirty447.08 ms469.04 ms21.96 ms
46bd012387.09 ms404.47 ms17.38 ms

App size

RevisionPlainWith SentryDiff
083f560+dirty17.75 MiB19.70 MiB1.96 MiB
ad27f6e+dirty43.75 MiB48.07 MiB4.32 MiB
f081f58+dirty43.75 MiB47.99 MiB4.24 MiB
d916aa317.75 MiB20.15 MiB2.41 MiB
294387d+dirty43.75 MiB48.04 MiB4.29 MiB
90afdd3+dirty17.75 MiB19.70 MiB1.95 MiB
e07935d+dirty43.75 MiB47.99 MiB4.24 MiB
9b50d32+dirty43.75 MiB48.04 MiB4.29 MiB
eec00c2+dirty43.75 MiB48.05 MiB4.29 MiB
46bd01217.75 MiB20.15 MiB2.41 MiB

Previous results on branch: cocoa-v9

Startup times

RevisionPlainWith SentryDiff
0816bdc+dirty420.64 ms447.37 ms26.73 ms
326e1a7+dirty426.45 ms457.84 ms31.39 ms
9aa9f9b+dirty464.02 ms490.62 ms26.60 ms

App size

RevisionPlainWith SentryDiff
0816bdc+dirty43.75 MiB48.07 MiB4.32 MiB
326e1a7+dirty43.75 MiB48.07 MiB4.32 MiB
9aa9f9b+dirty43.75 MiB48.07 MiB4.32 MiB

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 11, 2025•
edited
Loading

iOS (new) Performance metrics 🚀

 PlainWith SentryDiff
Startup time1220.00 ms1217.90 ms-2.10 ms
Size3.44 MiB4.74 MiB1.31 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
000da7a+dirty1204.50 ms1218.94 ms14.44 ms
d1bfbde+dirty1221.30 ms1218.70 ms-2.60 ms
59f3a84+dirty1205.09 ms1213.31 ms8.23 ms
5691430+dirty1191.06 ms1189.13 ms-1.94 ms
c4e097a+dirty1231.35 ms1246.91 ms15.56 ms
652f785+dirty1216.42 ms1212.21 ms-4.21 ms
88890fe+dirty1219.00 ms1222.08 ms3.08 ms
f081f58+dirty1208.37 ms1215.56 ms7.19 ms
276d348+dirty1222.10 ms1229.02 ms6.92 ms
ee69ed5+dirty1212.78 ms1214.91 ms2.13 ms

App size

RevisionPlainWith SentryDiff
000da7a+dirty3.19 MiB4.48 MiB1.29 MiB
d1bfbde+dirty3.41 MiB4.58 MiB1.17 MiB
59f3a84+dirty3.19 MiB4.56 MiB1.37 MiB
5691430+dirty3.41 MiB4.59 MiB1.18 MiB
c4e097a+dirty3.19 MiB4.44 MiB1.25 MiB
652f785+dirty3.41 MiB4.57 MiB1.16 MiB
88890fe+dirty3.19 MiB4.57 MiB1.38 MiB
f081f58+dirty3.41 MiB4.58 MiB1.17 MiB
276d348+dirty3.19 MiB4.54 MiB1.36 MiB
ee69ed5+dirty3.41 MiB4.59 MiB1.18 MiB

Previous results on branch: cocoa-v9

Startup times

RevisionPlainWith SentryDiff
9aa9f9b+dirty1217.00 ms1212.65 ms-4.35 ms
0816bdc+dirty1207.15 ms1214.24 ms7.10 ms
326e1a7+dirty1188.46 ms1201.64 ms13.18 ms

App size

RevisionPlainWith SentryDiff
9aa9f9b+dirty3.41 MiB4.74 MiB1.33 MiB
0816bdc+dirty3.44 MiB4.74 MiB1.30 MiB
326e1a7+dirty3.41 MiB4.74 MiB1.33 MiB

@github-actions
Copy link
Contributor

github-actionsbot commentedNov 11, 2025•
edited
Loading

iOS (legacy) Performance metrics 🚀

 PlainWith SentryDiff
Startup time1188.04 ms1198.19 ms10.15 ms
Size3.44 MiB4.74 MiB1.31 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
000da7a+dirty1214.31 ms1221.91 ms7.61 ms
d1bfbde+dirty1216.83 ms1212.83 ms-3.99 ms
59f3a84+dirty1232.56 ms1238.12 ms5.56 ms
5691430+dirty1218.89 ms1222.22 ms3.33 ms
c4e097a+dirty1229.09 ms1242.61 ms13.53 ms
652f785+dirty1219.66 ms1223.62 ms3.96 ms
88890fe+dirty1219.20 ms1231.00 ms11.80 ms
f081f58+dirty1219.10 ms1217.57 ms-1.53 ms
276d348+dirty1224.22 ms1227.38 ms3.16 ms
ee69ed5+dirty1206.79 ms1213.98 ms7.19 ms

App size

RevisionPlainWith SentryDiff
000da7a+dirty2.63 MiB3.91 MiB1.28 MiB
d1bfbde+dirty3.41 MiB4.58 MiB1.17 MiB
59f3a84+dirty2.63 MiB3.99 MiB1.36 MiB
5691430+dirty3.41 MiB4.59 MiB1.18 MiB
c4e097a+dirty2.63 MiB3.87 MiB1.24 MiB
652f785+dirty3.41 MiB4.57 MiB1.16 MiB
88890fe+dirty2.63 MiB4.00 MiB1.37 MiB
f081f58+dirty3.41 MiB4.58 MiB1.17 MiB
276d348+dirty2.63 MiB3.98 MiB1.34 MiB
ee69ed5+dirty3.41 MiB4.59 MiB1.18 MiB

Previous results on branch: cocoa-v9

Startup times

RevisionPlainWith SentryDiff
9aa9f9b+dirty1216.96 ms1214.32 ms-2.64 ms
0816bdc+dirty1223.46 ms1221.28 ms-2.18 ms
326e1a7+dirty1210.09 ms1217.29 ms7.20 ms

App size

RevisionPlainWith SentryDiff
9aa9f9b+dirty3.41 MiB4.74 MiB1.33 MiB
0816bdc+dirty3.44 MiB4.74 MiB1.30 MiB
326e1a7+dirty3.41 MiB4.74 MiB1.33 MiB

@antonisantonis changed the titlechore(deps): update Cocoa SDK to v9.0.0-alpha.0chore(deps): update Cocoa SDK to v9.0.0-alphaNov 13, 2025
@antonis
Copy link
ContributorAuthor

fix(podspec): Cocoa V9 allow any alpha version

Thank you@philipphofmann 🦸

philipphofmann reacted with thumbs up emoji

antonisand others added2 commitsNovember 13, 2025 12:00
* fix: Fixes SentryScreenFrames use after being converted to Swift* Fix build* Use non-experimental enableLogs* bump target* remove enable tracing* Update enableLogs tests* chore: Fix RNSentry after SentryFramesTracker conversion to swift* Run linter* Remove unused debug image provider imports* Remove imports* chore: Remove deprecated user property* chore: Remove use of deprecate integrations API (#5304)* Remove use of integrations in tests* chore: Remove use of deprecated prop (#5322)* ref: Move options to wrapper* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9---------Co-authored-by: Itay Brenner <itay.brenner@sentry.io>Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>Co-authored-by: Denis Andrasec <denrase@gmail.com>Co-authored-by: Noah Martin <noahm444@gmail.com>
* fix: Fixes SentryScreenFrames use after being converted to Swift* Fix build* Use non-experimental enableLogs* bump target* remove enable tracing* Update enableLogs tests* chore: Fix RNSentry after SentryFramesTracker conversion to swift* Run linter* Remove unused debug image provider imports* Remove imports* chore: Remove deprecated user property* chore: Remove use of deprecate integrations API (#5304)* Remove use of integrations in tests* chore: Remove use of deprecated prop (#5322)* ref: Move options to wrapper* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0* Bump to 15.1 due to RN 0.81.0 requirements---------Co-authored-by: Itay Brenner <itay.brenner@sentry.io>Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>Co-authored-by: Denis Andrasec <denrase@gmail.com>Co-authored-by: Noah Martin <noahm444@gmail.com>
@antonisantonis removed the ready-to-mergeTriggers the full CI test suite labelNov 13, 2025
@antonisantonis added the ready-to-mergeTriggers the full CI test suite labelNov 13, 2025
@antonisantonis changed the titlechore(deps): update Cocoa SDK to v9.0.0-rcchore(deps): update Cocoa SDK to v9.0.0 GADec 1, 2025
@lucas-zimerman
Copy link
Collaborator

V9 was released so I will unblock this issue

@antonis
Copy link
ContributorAuthor

V9 was released so I will unblock this issue

Correct. I'll keep it in draft for now since we are not going to merge on the main branch but on v8.

I've also openedgetsentry/sentry-cocoa#6942 that I hope is going to fix some ofthe issues

@antonisantonis changed the titlechore(deps): update Cocoa SDK to v9.0.0 GAchore(deps): update Cocoa SDK to v9Dec 11, 2025
@antonisantonis removed the ready-to-mergeTriggers the full CI test suite labelDec 11, 2025
@antonisantonis added the ready-to-mergeTriggers the full CI test suite labelDec 11, 2025
@antonis
Copy link
ContributorAuthor

The CI is 🟢 again with9.1.0 and thecurrent issues are solved. The sample app also behaved as expected in my manual tests 🎉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alwxalwxAwaiting requested review from alwxalwx will be requested when the pull request is marked ready for reviewalwx is a code owner

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman will be requested when the pull request is marked ready for reviewlucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ready-to-mergeTriggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@antonis@lucas-zimerman@itaybre@denrase@philipphofmann@noahsmartin
[8]ページ先頭
©2009-2025 Movatter.jp