Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(size-limit): Add size checks for metrics and logs#18573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Lms24 wants to merge5 commits intodevelop
base:develop
Choose a base branch
Loading
fromlms/chore-size-limit-metrics-logs

Conversation

@Lms24
Copy link
Member

@Lms24Lms24 commentedDec 19, 2025
edited
Loading

This PR adds 3 size-limit entries for logs, metrics and both combined. I have some optimizations lined up for reducing bundle size in both but I need a baseline to see if they actually do any good.

ref#18571
ref#18164

sentry[bot] reacted with hooray emoji
@github-actions
Copy link
Contributor

github-actionsbot commentedDec 19, 2025
edited
Loading

size-limit report 📦

PathSize% ChangeChange
@sentry/browser24.82 kB--
@sentry/browser - with treeshaking flags23.32 kB--
@sentry/browser (incl. Tracing)41.59 kB--
@sentry/browser (incl. Tracing, Profiling)46.2 kB--
@sentry/browser (incl. Tracing, Replay)80.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.91 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)84.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)97.1 kB--
@sentry/browser (incl. Feedback)41.54 kB--
@sentry/browser (incl. sendFeedback)29.51 kB--
@sentry/browser (incl. FeedbackAsync)34.5 kB--
@sentry/react26.54 kB--
@sentry/react (incl. Tracing)43.79 kB--
@sentry/vue29.29 kB--
@sentry/vue (incl. Tracing)43.41 kB--
@sentry/svelte24.84 kB--
CDN Bundle27.25 kB--
CDN Bundle (incl. Tracing)42.24 kB--
CDN Bundle (incl. Tracing, Replay)78.95 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)84.42 kB--
CDN Bundle - uncompressed80.06 kB--
CDN Bundle (incl. Tracing) - uncompressed125.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed241.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed254.71 kB--
@sentry/nextjs (client)46.01 kB--
@sentry/sveltekit (client)41.97 kB--
@sentry/node-core51.61 kB--
@sentry/node161.5 kB--
@sentry/node - without tracing93.05 kB--
@sentry/aws-serverless108.56 kB--
@sentry/browser (incl. Metrics)25.85 kBaddedadded
@sentry/browser (incl. Logs)26.07 kBaddedadded
@sentry/browser (incl. Metrics & Logs)26.73 kBaddedadded

View base workflow run

{
name:'@sentry/browser (incl. Metrics)',
path:'packages/browser/build/npm/esm/prod/index.js',
import:createImport('init','metrics'),
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

tbh, I was surprised that the import ofmetrics andlogs is enough in this case because I was under the impression that just importing this object would still tree-shake the implementation of the individual log/metric operations.

However, I inspected the bundle created by size-limit and it turns out that they're still included.

Also further verified this with creating a custom entry file and writinglogger.info, etc statements and in either case, the resulting bundle was smaller than just specifying thelogger/metric import. So I think we should take this as the upper bound.

@Lms24Lms24 self-assigned thisDec 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chargomechargomechargome approved these changes

@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees

@Lms24Lms24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome

[8]ページ先頭

©2009-2025 Movatter.jp