Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork178
PHPUnit replace covers annotations with attributes#6985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
76ecbe7
to1899693
Compare1899693
tof43521f
CompareClosing this - will do smaller PRs per package or so later on. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Form\Field
namespace #6986Summary of changes
@covers
/@coversDefaultClass
and@dataProvider
annotations with PHP attributesReasoning
PHPUnit will remove docblock annotation support in v12, already throwing deprecation notices in v11.
PHPUnit does offer a
CoversMethod
attribute. However, this can only be applied per class, not to a specific test method. As such, I don't think there is much value in it. That's why I followed a onlyCoversClass
approach (which is also the preferred one by the maintainer of PHPUnit).Additional context
Doesn't remove all PHPUnit deprecation errors but the biggest chunk.
Changelog
Housekeeping
Ready?
For review team