Commit7a87ee3

authored and

committed

fix: assign a generated className to elements inside nested arrays (#292)

1 parent982fcf5 commit7a87ee3Copy full SHA for 7a87ee3

File tree

+28

-8

lines changed

+28

-8

lines changed

Lines changed: 1 addition & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,14 +50,7 @@ const linkElement = (element: ReactElement, styles: Object, configuration: Objec`
`50`	`50`	`if(React.isValidElement(children)){`
`51`	`51`	`elementShallowCopy.props.children=linkElement(React.Children.only(children),styles,configuration);`
`52`	`52`	`}elseif(_.isArray(children)\|\|isIterable(children)){`
`53`		`-elementShallowCopy.props.children=_.map(children,(node)=>{`
`54`		`-if(React.isValidElement(node)){`
`55`		`-// eslint-disable-next-line no-use-before-define`
`56`		`-returnlinkElement(React.Children.only(node),styles,configuration);`
`57`		`-}else{`
`58`		`-returnnode;`
`59`		`-}`
`60`		`-});`
	`53`	`+elementShallowCopy.props.children=linkArray(objectUnfreeze(children),styles,configuration);`
`61`	`54`	`}`
`62`	`55`
`63`	`56`	`_.forEach(restProps,(propValue,propName)=>{`

Lines changed: 27 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,33 @@ describe('linkClass', () => {`
`125`	`125`	`expect(subject.props.children[0].props.className).to.equal('foo-1');`
`126`	`126`	`expect(subject.props.children[1].props.className).to.equal('bar-1');`
`127`	`127`	`});`
	`128`	`+it('assigns a generated className to elements inside nested arrays',()=>{`
	`129`	`+letsubject;`
	`130`	`+`
	`131`	`+subject=<div>`
	`132`	`+{[`
	`133`	`+[`
	`134`	`+<pkey='1'styleName='foo'/>,`
	`135`	`+<pkey='2'styleName='bar'/>`
	`136`	`+],`
	`137`	`+[`
	`138`	`+<pkey='1'styleName='foo'/>,`
	`139`	`+<pkey='2'styleName='bar'/>`
	`140`	`+]`
	`141`	`+]}`
	`142`	`+</div>;`
	`143`	`+`
	`144`	`+subject=linkClass(subject,{`
	`145`	`+bar:'bar-1',`
	`146`	`+foo:'foo-1'`
	`147`	`+});`
	`148`	`+`
	`149`	`+expect(subject.props.children[0][0].props.className).to.equal('foo-1');`
	`150`	`+expect(subject.props.children[0][1].props.className).to.equal('bar-1');`
	`151`	`+`
	`152`	`+expect(subject.props.children[1][0].props.className).to.equal('foo-1');`
	`153`	`+expect(subject.props.children[1][1].props.className).to.equal('bar-1');`
	`154`	`+});`
`128`	`155`	`it('styleName is deleted from props',()=>{`
`129`	`156`	`letsubject;`
`130`	`157`

Comments

(0)