- Notifications
You must be signed in to change notification settings - Fork6
Added relative path get and set#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ruisilva450 wants to merge1 commit intog-makarov:mainChoose a base branch fromruisilva450:add-relative-set-get-by-patch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+117 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm coming from a specific use case on my side where I have an initial path and want to manipulate the object with a relative path from the initial.
After getting it working I thought it could be useful to include it on your package.
Explanation
We are going to start with this object:
This PR is composed into two parts:
getByRelativePath(obj, path, relativePath)
'a.d.0'../../bgetByRelativePath(obj, 'a.d.0', '../../b')'../../'takes the context toa) and step forward once ('b'takes the context toa.b)'hello'setByRelativePath(obj, path, relativePath, value)
'a.d.0'../../bsetByRelativePath(obj, 'a.d.0', '../../b', 'good morning')'../../'takes the context toa) and step forward once ('b'takes the context toa.b)obj.a.b === 'good morning'Note: Take into account that I'm not well knowledgeable in typescript and learned a good deal with your code. Still I know there is some work to be done on this PR related with that.
Can I get some help on that maybe? :)