Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Fixed a Few Compiler Warnings#4290

Open
1eyewonder wants to merge1 commit intofsprojects:master
base:master
Choose a base branch
Loading
from1eyewonder:warn-fixes

Conversation

1eyewonder
Copy link
Contributor

@1eyewonder1eyewonder commentedJan 30, 2025
edited
Loading

Here are a few fixes to some compiler warnings we are getting on builds. I'm wanting to try and go through and attempt to do a few rounds of cleanup to make real issues more obvious when we encounter them.

I'll be making separate PRs for:

  1. InstallModel.CreateFromLibs -> InstallModel.CreateFromContent
    1. There are a lot of warnings we can clean up here
  2. build.fsx
    1. I think we can eliminate a lot of these warnings by updating our FAKE dependencies and referencing the modern core namespaces instead

smoothdeveloper reacted with heart emoji
@smoothdeveloper
Copy link
Contributor

Can you base your PRs on top of#4281?

It already enables warning as errors, while leaving those that are a bit invasive to fix in the codebase.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@1eyewonder@smoothdeveloper

[8]ページ先頭

©2009-2025 Movatter.jp