Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Diagram representation of the freqtrade codebase for onboarding#11893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xmatthias commentedJun 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This looks like a bot PR if i'm honest - and i'm sure the output is - thought he PR might be cold outreach ... so let's try with a few questions first. I don't see how a random, hidden, non-standard directory, which doesn't render as part of the docs would help users with onboarding. There's essentially no details in this. While it's great that it "might" be able to update automatically - it seems pretty much AI generated - and you can see that from afar. So far - i'm not impressed - as it got some things wrong. There's a couple of questions that come to mind before even trying to look at what you're trying to add...
|
Hey, thanks for the fast response@xmatthias and thank you for the feedback and the questions! On your questions:
The .codeboarding directory is just something that we chose as this is the name that we are currently running with. As said in the PR I'd usually do a discussion before PR, but aren't enabled for this repository. |
I'll be quite honest - freqtrade is a small project, with an even smaller maintainer range - so we'll not be playing the "test bunnies" for a potential startup. Are there any bigger / popular repositories that are already using this successfully? |
After having a small look around to see how other projects respond (e.g.matplotlib/matplotlib#30135,psf/requests#6958) - i'm going to close this for similar reason than theirs. This seems to be some combination of SEO (many backlings to your repo), market research (would people be open for it) combined with abusing open source maintainer's free time to test your product. The approach taken in this PR is not something I'd accept into this project. Also the text is mostly useless and will waste people's time trying to learn the codebase. (example - especially the second part):
This seems good at first - but has 0 clarity which realm these helpers go in. Instead of explaining that a common module promotes code reuse (that's what the name says) - describing the content (provides exchange retry methods, ...) is 100% more helpful to users. Similar (completely pointless) sentences are throughout some random parts i reviewed - so while it may provide some overview - the explanations need a TON of work. Feel free to re-submit / open as idea once it's an open source project we can control fully (as in - it's an open source github action or mkdocs plugin, running in our repository, where we get some control over the quality of the output). For the future (not least because you got the same feedback elsewhere) - you shouldn't open random PR's just because discussions are closed - the proper replacement for a discussion is an issue, not a Pull Request. |
Summary
Adding markdown documentation to help new people get up-to-speed with the freqtrade codebase.
You can see how it renders here:
https://github.com/CodeBoarding/GeneratedOnBoardings/blob/main/freqtrade/on_boarding.md
Quick changelog
What's new?
I've added high-level diagram representation of the codebase, which aims to help people to familiarize themselves with the existing codebase and then have context for the components they want to start working with. The aimed user of this documents is a new contributor!
Any feedback is more than welcome! We've just released a free GitHub Action that can automatically update the diagrams and this way keep them always up-to-date.
Full disclosure: we're trying to turn this into a startup, but we're still in a very early stage and figuring out what will actually be useful for people.
I would usually start by opening a discussion, but they are not enabled for this repository so I opened a PR instead!