- Notifications
You must be signed in to change notification settings - Fork502
fix(plugin): merge cond property of import specs#1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
overhacked wants to merge1 commit intofolke:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+45 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When a spec had an `import` property, the `cond` property was treatedthe same as `enabled`; any specs to be imported were ignored and treatedas uninstalled if `cond` evaluated to false. This is inconsistent withhow `cond` behaves in a plugin spec without an `import` property.To make the behavior consistent when using `import` to manage submodulesof plugin specs, merge the `cond` property of the "parent" spec(s)containing an `import` property with any `cond` property found on theimported "child" spec(s), including nested `import` specs. The parentand child `cond` properties are evaluated and combined with boolean`and`.Signed-off-by: Ross Williams <ross@ross-williams.net>
This PR is stale because it has been open 30 days with no activity. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a spec had an
importproperty, thecondproperty was treated the same asenabled; any specs to be imported were ignored and treated as uninstalled ifcondevaluated to false. This is inconsistent with howcondbehaves in a plugin spec without animportproperty.To make the behavior consistent when using
importto manage submodules of plugin specs, merge thecondproperty of the "parent" spec(s) containing animportproperty with anycondproperty found on the imported "child" spec(s), including nestedimportspecs. The parent and childcondproperties are evaluated and combined with booleanand.Related Issue(s)
None
Screenshots
N/A