Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1k
feat: Add support to multiple lights using the uniform array [flame3d][WIP]#3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
luanpotter wants to merge3 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+25 −57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
6 tasks
8158d30 to9132ee8Compare9fb50a3 to02b35b4Compare1 task
luanpotter added a commit that referenced this pull requestSep 21, 2024
…_3d] (#3282)Refactor shader uniform binding to support shader arrays.This also decouples the whole shader and uniform byte handling code(that we should definitely test) from the flutter_gpu primitives thatare impossible to mock (base native classes).This adds tests that ensure the arrays are bound as they should -however the underlying flutter_gpu code does not seem to work. See [thisPR](#3284) for a test of usingthis to support an arbitrary number of lights.Either way, we can merge this as is as this refactors the underlyingstructure to support arrays when ready, and make it more testable aswell.
luanpotter added a commit that referenced this pull requestOct 15, 2024
…_3d] (#3282)Refactor shader uniform binding to support shader arrays.This also decouples the whole shader and uniform byte handling code(that we should definitely test) from the flutter_gpu primitives thatare impossible to mock (base native classes).This adds tests that ensure the arrays are bound as they should -however the underlying flutter_gpu code does not seem to work. See [thisPR](#3284) for a test of usingthis to support an arbitrary number of lights.Either way, we can merge this as is as this refactors the underlyingstructure to support arrays when ready, and make it more testable aswell.
luanpotter added a commit that referenced this pull requestDec 11, 2024
…_3d] (#3282)Refactor shader uniform binding to support shader arrays.This also decouples the whole shader and uniform byte handling code(that we should definitely test) from the flutter_gpu primitives thatare impossible to mock (base native classes).This adds tests that ensure the arrays are bound as they should -however the underlying flutter_gpu code does not seem to work. See [thisPR](#3284) for a test of usingthis to support an arbitrary number of lights.Either way, we can merge this as is as this refactors the underlyingstructure to support arrays when ready, and make it more testable aswell.
02b35b4 tob8762ecCompareluanpotter added a commit that referenced this pull requestDec 11, 2024
…_3d] (#3282)Refactor shader uniform binding to support shader arrays.This also decouples the whole shader and uniform byte handling code(that we should definitely test) from the flutter_gpu primitives thatare impossible to mock (base native classes).This adds tests that ensure the arrays are bound as they should -however the underlying flutter_gpu code does not seem to work. See [thisPR](#3284) for a test of usingthis to support an arbitrary number of lights.Either way, we can merge this as is as this refactors the underlyingstructure to support arrays when ready, and make it more testable aswell.
b8762ec to416acd7Compare416acd7 to3e36235Comparee49e5aa to55c1aadCompareMemberAuthor
luanpotter commentedOct 19, 2025
@wolfenrain would love some help with getting this working when you have some time. I've tried so many different approaches and the issue truly eludes me. |
Contributor
wolfenrain commentedOct 19, 2025
I'll try and have a jab at it 🫡 |
nickf2k pushed a commit to nickf2k/flame that referenced this pull requestNov 16, 2025
…_3d] (flame-engine#3282)Refactor shader uniform binding to support shader arrays.This also decouples the whole shader and uniform byte handling code(that we should definitely test) from the flutter_gpu primitives thatare impossible to mock (base native classes).This adds tests that ensure the arrays are bound as they should -however the underlying flutter_gpu code does not seem to work. See [thisPR](flame-engine#3284) for a test of usingthis to support an arbitrary number of lights.Either way, we can merge this as is as this refactors the underlyingstructure to support arrays when ready, and make it more testable aswell.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support to multiple lights using the uniform array
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?