NotificationsYou must be signed in to change notification settings
Fork609
Star5.2k

fix(go/core/reflection): do not send new line at the end of action run stream#3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

pavelgj wants to merge5 commits intomain

base:main

Choose a base branch

frompj/fix-reflection-streaming-final-result

Open

fix(go/core/reflection): do not send new line at the end of action run stream#3972

pavelgj wants to merge5 commits intomainfrompj/fix-reflection-streaming-final-result

+102 −11

Conversation

Copy link

Collaborator

pavelgj commentedDec 17, 2025

Checklist (if applicable):

PR title is followinghttps://www.conventionalcommits.org/en/v1.0.0/
Tested (manually, unit tested, etc.)
Docs updated (updated docs or a docs bug required)

fix(go/core/reflection): do not send new line at the end of action ru…

0b2e271

…n stream

github-project-automationbot added this toGenkit Backlog

Dec 17, 2025

pavelgj requested review fromapascal07 andhuangjeff5

December 17, 2025 19:26

github-actionsbot added go fix labels

Dec 17, 2025

Copy link

Contributor

gemini-code-assistbot commentedDec 17, 2025

Summary of Changes

Hello@pavelgj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where an unintended newline character was being appended to the JSON output of action run streams. By switching to a more explicit JSON marshaling and writing process, the change ensures that the stream's response contains only the intended JSON data, improving the correctness and predictability of the API for consumers.

Highlights

Newline Character Removal: The pull request modifies the action run stream handler to prevent an unwanted newline character from being sent at the end of the JSON response.
JSON Encoding Method Change: The method for encoding JSON responses has been updated fromjson.NewEncoder(w).Encode() to a manualjson.Marshal() followed byw.Write(data), providing more control over the output.
Error Handling for JSON Marshaling: New error handling has been introduced for thejson.Marshal operation, ensuring that marshaling failures are caught and an appropriateReflectionError is returned.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

gemini-code-assistbot reviewed

Dec 17, 2025

View reviewed changes

Copy link

Contributor

gemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request aims to fix an issue where an extra newline character is appended to the end of a streaming action response. The change correctly replacesjson.NewEncoder(...).Encode() withjson.Marshal() followed byw.Write() to avoid the unwanted newline. While the main change is correct, I've found a potential bug in the new error handling logic and provided a suggestion to fix it.