Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Angular peer dependencies#9432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
andrewbrook merged 2 commits intotelemetryfromtelemetry1
Dec 18, 2025
Merged

Add Angular peer dependencies#9432

andrewbrook merged 2 commits intotelemetryfromtelemetry1
Dec 18, 2025

Conversation

@andrewbrook
Copy link

Discussion

Set minimum versions for Angular peer dependencies

Testing

N/A

API Changes

N/A

@changeset-bot
Copy link

changeset-botbot commentedDec 18, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:e9e372e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello@andrewbrook, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces essential Angular peer dependencies to thecrashlytics package. By specifying minimum version requirements for@angular/core and@angular/router, it ensures proper compatibility and integration when the package is used within Angular applications.

Highlights

  • Angular Peer Dependencies: Added@angular/core and@angular/router with a minimum version of3.0.0 to thepeerDependencies inpackages/crashlytics/package.json.

🧠New Feature in Public Preview: You can now enableMemory to helpGemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style.Clickhere to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either/gemini <command> or@gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

FeatureCommandDescription
Code Review/gemini reviewPerforms a code review for the current pull request in its current state.
Pull Request Summary/gemini summaryProvides a summary of the current pull request in its current state.
Comment@gemini-code-assistResponds in comments when explicitly tagged, both in pull request comments and review comments.
Help/gemini helpDisplays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a.gemini/ folder in the base of the repository. Detailed instructions can be foundhere.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension.

Footnotes

  1. Review thePrivacy Notices,Generative AI Prohibited Use Policy,Terms of Service, and learn how to configure Gemini Code Assist in GitHubhere. Gemini can make mistakes, so double check it anduse code with caution.↩

@andrewbrookandrewbrook marked this pull request as ready for reviewDecember 18, 2025 19:41
@andrewbrookandrewbrook requested a review froma team as acode ownerDecember 18, 2025 19:41
Copy link
Contributor

@gemini-code-assistgemini-code-assistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code Review

This pull request adds peer dependencies for@angular/core and@angular/router to thecrashlytics package. While this is a good addition, the specified minimum version of>= 3.0.0 is incorrect. The Angular integration code uses theinject() function, which requires at least Angular version 14. I've suggested updating the version constraints to reflect this requirement to avoid issues for developers on older Angular versions.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@google-oss-bot
Copy link
Contributor

google-oss-bot commentedDec 18, 2025•
edited
Loading

@google-oss-bot
Copy link
Contributor

google-oss-bot commentedDec 18, 2025•
edited
Loading

@andrewbrookandrewbrook merged commite3691f6 intotelemetryDec 18, 2025
42 of 45 checks passed
@andrewbrookandrewbrook deleted the telemetry1 branchDecember 18, 2025 20:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tonybaroneeetonybaroneeetonybaroneee approved these changes

+1 more reviewer

@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewbrook@google-oss-bot@tonybaroneee
[8]ページ先頭
©2009-2025 Movatter.jp