- Notifications
You must be signed in to change notification settings - Fork410
fix(rtdb): Apply fake credentials when getting rules for rtdb emulator#3028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Summary of ChangesHello@amalej, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where fetching Realtime Database rules ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on ourdocumentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on@gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign uphere. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with theGemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Code Review
This pull request addresses an issue with getting Realtime Database rules when using the emulator. The fix involves creating a newDatabaseRulesHttpClient which provides a hardcoded 'owner' token when the database emulator is detected. The changes are logical and well-targeted. My review includes a suggestion to encapsulate the magic string 'owner' as a constant within the new class to improve code clarity and maintainability.
| classDatabaseRulesHttpClientextendsAuthorizedHttpClient{ | ||
| protectedgetToken():Promise<string>{ | ||
| constemulatorHost=process.env.FIREBASE_DATABASE_EMULATOR_HOST; | ||
| if(emulatorHost){ | ||
| returnPromise.resolve('owner'); | ||
| } | ||
| returnsuper.getToken(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To improve readability and maintainability, it's a good practice to avoid magic strings. Consider defining'owner' as a private static constant within the class.
classDatabaseRulesHttpClientextendsAuthorizedHttpClient{privatestaticreadonlyEMULATOR_AUTH_TOKEN='owner';protectedgetToken():Promise<string>{constemulatorHost=process.env.FIREBASE_DATABASE_EMULATOR_HOST;if(emulatorHost){returnPromise.resolve(DatabaseRulesHttpClient.EMULATOR_AUTH_TOKEN);}returnsuper.getToken();}}
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about thisbefore creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.
Fixes#2034
Running the ff code:
Outputs