- Notifications
You must be signed in to change notification settings - Fork3.6k
feat: add support for sql-based databases#2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
813c2e9 to66dfbb3Comparepkuwwt commentedDec 21, 2023
conflicts resolved@o1egl |
sevmonster commentedFeb 6, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can any effort be put into merging this? Filebrowser CLI cannot be used inside container or while it's running in general, because of the exclusive database lock. This is seriously inconvenient. I am forced at this point to either kill filebrowser every time I want to run a CLI command, or build this PR for use in production. This also affects automation and makes it difficult to programmatically add users (for example) based on other input. I would use the API but it is not documented and seems fiddly to use,#2551. |
sevmonster commentedFeb 7, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I built this and merged with
|
pkuwwt commentedFeb 9, 2024
@sevmonster |
hacdias commentedNov 14, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hey! Thanks for all the effort put into this. I do agree that this could be useful, but it's quite a large change and effort to maintain. As such, I am parking this now, but leaving the PR open. |
Uh oh!
There was an error while loading.Please reload this page.
Description
Add sql support in addition to bolt, including sqlite3, postgres, mysql.
Most code are in
storage/sql, except a few lines incmd/root.goandcmd/utils.go.Usage
filebrowser -d sqlite3://test.dbfilebrowser -d'postgres://user:password@192.168.1.100:5432/postgres?sslmode=disable'Reason
Bolt is a relative non-mainstream choice for storage. When someone use filebrowser as a component of a project, he/she will need a centralized storage server, e.g. postgres, mysql, other than bolt.