Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: add support for response header rendering for status code 204#1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
abhishekmsingh wants to merge1 commit intoferdikoomen:main
base:main
Choose a base branch
Loading
fromabhishekmsingh:feat-add-support-for-response-header-statuscode204

Conversation

@abhishekmsingh
Copy link

While having a spec like

"responses": {"204": {"description":"Success","headers": {"X-Auth-Token": {"description":"header containing the auth token","schema": {"type":"string"                                }                            }                        }                    },"401": {"description":"Unauthorized"                    },"422": {"description":"Validation Error","content": {"application/json": {"schema": {"$ref":"#/components/schemas/HTTPValidationError"                                }                            }                        }                    }                }

we don't get the responseheader hook in the generated clientservice since it is filtered out. Whereas according to HTTP spec(https://www.rfc-editor.org/rfc/rfc9110.html#section-15.3.5-1) and MDN docs(https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#successful_responses) 204 can include headers

@abhishekmsingh
Copy link
Author

@ferdikoomen review?

@abhishekmsinghabhishekmsingh marked this pull request as draftJanuary 3, 2024 20:05
@abhishekmsinghabhishekmsingh changed the titleadd support for response header rendering for status code 204fix: add support for response header rendering for status code 204Jan 3, 2024
@mrlubos
Copy link
Collaborator

Hey @abhiandthetruth, please check out ourfork, that might have what you're looking for

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abhishekmsingh@mrlubos
[8]ページ先頭
©2009-2025 Movatter.jp