Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.4k
lsp: use FullDocumentation hover response#3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bhcleek wants to merge1 commit intofatih:masterChoose a base branch frombhcleek:gopls/hover/structured-deprecated
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
eef9192 tobbfd039CompareUse the FullDocumentation hover response instead of Structured, becausethe latter is deprecated and will be removed soon.* Parse FullDocumentation format for use in a hover message, following the same basic format was was previously provided by gopls in its Structured format.* Refactor handlers that relied on the hover response to expect the structured output from the new function that provides it.* Refactor functions that expected documentation links to first rely on a new request, documentLink via go#lsp#DocLink, and then falling back to trusty `go doc` to get what's needed.
bbfd039 toc1099e3CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the FullDocumentation hover response instead of Structured, because the latter is deprecated and will be removed soon.
Fixes#3701