✅ Fix incorrect mocking in unit tests (issue #1780)#1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

vicaya wants to merge2 commits intofastapi:master

base:master

Choose a base branch

fromvicaya:fix_backend_init_tests

Open

✅ Fix incorrect mocking in unit tests (issue #1780)#1781

vicaya wants to merge2 commits intofastapi:masterfromvicaya:fix_backend_init_tests

+12 −12

Conversation

Copy link

vicaya commentedAug 20, 2025•
edited
Loading

Fix issue#1780: the 2test_init_successful_connection tests were basically noops due to misuse of MagicMock.

The errors went undetected until python 3.12+ tightened up the MagicMock implementation.

YuriiMotov added the refactor label

Sep 3, 2025

YuriiMotov changed the title~~Fix broken unit tests #1780~~✅ Fix broken unit tests (issue #1780)

Sep 3, 2025

YuriiMotov approved these changes

Sep 3, 2025

View reviewed changes

Copy link

Member

YuriiMotov left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

I suggest removing several lines to simplify tests (I tested it locally - it doesn't break tests).

Currently if you replacesession.exec(select(1)) inthis line withpass,this assertion will not fail as it's expected.
This PR fixes mocking theSession and after applying it, that test will not only ensure that there was no exception ininit, but also thatselect(1) was actually called.

The same forhttps://github.com/fastapi/full-stack-fastapi-template/blob/master/backend/app/tests/scripts/test_test_pre_start.py

@vicaya, thank you!
~~Could you please take a look at my suggested changes?~~ (done)