Commite7ea066

authored and

committed

igl | vulkan | Return the waiting result fromPlatformDevice::waitOnSubmitHandle()

Reviewed By: xiendong, rudybearDifferential Revision: D71230828fbshipit-source-id: ac84eeb4921b46f2f87bc7a04276119568b87acb

1 parentdf41c6e commite7ea066Copy full SHA for e7ea066

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -174,16 +174,17 @@ VkFence PlatformDevice::getVkFenceFromSubmitHandle(SubmitHandle handle) const {`
`174`	`174`	`return vkFence;`
`175`	`175`	`}`
`176`	`176`
`177`		`-voidPlatformDevice::waitOnSubmitHandle(SubmitHandle handle,uint64_t timeoutNanoseconds)const {`
	`177`	`+boolPlatformDevice::waitOnSubmitHandle(SubmitHandle handle,uint64_t timeoutNanoseconds)const {`
`178`	`178`	`if (handle ==0) {`
`179`	`179`	`IGL_LOG_ERROR("Invalid submit handle passed to waitOnSubmitHandle");`
`180`		`-return;`
	`180`	`+returnfalse;`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`constauto& ctx = device_.getVulkanContext();`
`184`	`184`	`constauto& immediateCommands = ctx.immediate_;`
`185`	`185`
`186`		`- immediateCommands->wait(VulkanImmediateCommands::SubmitHandle(handle), timeoutNanoseconds);`
	`186`	`+return immediateCommands->wait(VulkanImmediateCommands::SubmitHandle(handle),`
	`187`	`+ timeoutNanoseconds) != VK_TIMEOUT;`
`187`	`188`	`}`
`188`	`189`
`189`	`190`	`#if defined(IGL_PLATFORM_ANDROID) && defined(VK_KHR_external_fence_fd)`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ class PlatformDevice : public IPlatformDevice {`
`54`	`54`
`55`	`55`	`/// Waits on the GPU Fence associated with the handle`
`56`	`56`	`/// @param handle The handle to the GPU Fence`
`57`		`-voidwaitOnSubmitHandle(SubmitHandle handle,uint64_t timeoutNanoseconds = UINT64_MAX)const;`
	`57`	`+/// @return 'true' when ready or 'false' on time out (can be ignored)`
	`58`	`+// NOLINTNEXTLINE(modernize-use-nodiscard)`
	`59`	`+boolwaitOnSubmitHandle(SubmitHandle handle,uint64_t timeoutNanoseconds = UINT64_MAX)const;`
`58`	`60`
`59`	`61`	`/// Android only for now - Creates the file descriptor for the underlying VkFence`
`60`	`62`	`/// @param handle The handle to the GPU Fence`

Comments

(0)