- Notifications
You must be signed in to change notification settings - Fork46
Drop unused 1bpp support from Stretch LCD code#792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jabrena commentedJan 10, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi Jakub, can you remember what is:
I don’t remember it. We added 2 years ago +- Did you test the branch with the brick? Here, you have an example to test that everything goes well: |
No, I don't currently have a free SD card (currently it is used by a non-robotic RPi, although I can reflash it later). I think I remember that Jessie used 1bpp packed black and white bitmaps and Stretch used 32bpp XRGB8888 bitmaps. However, because the Jessie codepath somehow didn't work, the old LCD implementation was copied over untouched and the new code is used only on Stretch (and Buster nowadays). |
9109c60 tob736a39CompareHi Jakub, did you test it? |
Not yet, and as such I have to close this PR. |
jabrena commentedJan 11, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
When you test in local, I will merge it. |
Related to#791