Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Drop unused 1bpp support from Stretch LCD code#792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JakubVanek wants to merge2 commits intoev3dev-lang-java:master
base:master
Choose a base branch
Loading
fromJakubVanek:cleanup/1bpp-lcd

Conversation

@JakubVanek
Copy link
Contributor

Related to#791

@jabrena
Copy link
Member

jabrena commentedJan 10, 2021
edited
Loading

Hi Jakub, can you remember what is:

  • Drop unused 1bpp support

I don’t remember it. We added 2 years ago +-

Did you test the branch with the brick?

Here, you have an example to test that everything goes well:
https://github.com/ev3dev-lang-java/template-project-gradle/blob/master/src/main/java/example/programming/FractalCircle.java

@JakubVanek
Copy link
ContributorAuthor

Did you test the branch with the brick?

No, I don't currently have a free SD card (currently it is used by a non-robotic RPi, although I can reflash it later).

I think I remember that Jessie used 1bpp packed black and white bitmaps and Stretch used 32bpp XRGB8888 bitmaps. However, because the Jessie codepath somehow didn't work, the old LCD implementation was copied over untouched and the new code is used only on Stretch (and Buster nowadays).

@jabrena
Copy link
Member

Hi Jakub, did you test it?

@JakubVanek
Copy link
ContributorAuthor

Not yet, and as such I have to close this PR.

@jabrena
Copy link
Member

jabrena commentedJan 11, 2021
edited
Loading

When you test in local, I will merge it.
The idea is good

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JakubVanek@jabrena

[8]ページ先頭

©2009-2025 Movatter.jp