Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Resolves #106: Implementingskip-empty-xacts.#120

Open
bahaa wants to merge3 commits intoeulerto:master
base:master
Choose a base branch
Loading
frombahaa:skip_empty_xacts

Conversation

bahaa
Copy link

@bahaabahaa commentedJun 28, 2019
edited
Loading

Adding new parameterskip-empty-xacts. I chose the same parameter name as Postgres'test_decoding.

This shouldresolve#106.

joekohlsdorf, qweeze, svilensabev, scaint, and kdwyer reacted with thumbs up emoji
@joekohlsdorf
Copy link

What is the reasoning behind not defaulting this totrue?

@bahaa
Copy link
Author

@joekohlsdorf backward compatibility. I think the plugin should behave the same for current users. Current users already get empty transactions and I think they are dealing with them already.

@joekohlsdorf
Copy link

In this particular case I would argue that the users aren't doing anything with empty transactions. So there is nothing lost by removing them because they contain no information at all.
They are just wasting network bandwidth and CPU cycles, depending on the use case this can require a substantial amount of additional processing.

@qweeze
Copy link

qweeze commentedFeb 8, 2020
edited
Loading

Any chance of merging this PR?

@eulerto
Copy link
Owner

@qweeze this PR is incomplete. It should be implemented in both format.@bahaa do you want to update this PR? Also, use a single commit.

@bahaa
Copy link
Author

@eulerto sure. I can update it on the weekend. What do you mean by "both formats"?

@jmealo
Copy link

@bahaa: there's an optionformat-version which can be either 1 or 2 (see README) -- anything new needs to support both versions.

@bahaa
Copy link
Author

@jmealo Thank you. I forked my version before there was support for two formats. I'll try to fix it this weekend.

hwildwood reacted with heart emoji

@ajitj
Copy link

Looking forward to getting this feature.@bahaa any update on this?
Thanks

scaint and hwildwood reacted with thumbs up emoji

@llehtinen
Copy link

@bahaa would be great to get this merged

@jehanzebqayyum
Copy link

@bahaa pls merge this.

@adrijshikhar
Copy link

@bahaa if you are unable to work on this, I will be more than happy to take it further.

@bahaa
Copy link
Author

@adrijshikhar sure. I'd be so glad if you do.

@adrijshikhar
Copy link

sure i will pick this up

@adrijshikhar
Copy link

#248

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting an overwhelming amount of transactions with empty change sets despite using add-tables
9 participants
@bahaa@joekohlsdorf@qweeze@eulerto@jmealo@ajitj@llehtinen@jehanzebqayyum@adrijshikhar

[8]ページ先頭

©2009-2025 Movatter.jp