Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add more extensive runtime metrics#21029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tjungblu wants to merge1 commit intoetcd-io:main
base:main
Choose a base branch
Loading
fromtjungblu:gogc_metrics

Conversation

@tjungblu
Copy link
Contributor

I've noticed that K8s and apiserver contains several metrics that etcd does not have. This PR adds the missing metrics to the default Prometheus registry.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:tjungblu
Once this PR has been reviewed and has the lgtm label, please assignspzala for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

DetailsNeeds approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@codecov
Copy link

codecovbot commentedDec 17, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.23%. Comparing base (893aab0) to head (1e457e3).

Additional details and impacted files
Files with missing linesCoverage Δ
server/etcdserver/metrics.go83.67% <100.00%> (+0.69%)⬆️

... and23 files with indirect coverage changes

@@            Coverage Diff             @@##             main   #21029      +/-   ##==========================================+ Coverage   69.18%   69.23%   +0.05%==========================================  Files         422      422                Lines       34841    34843       +2     ==========================================+ Hits        24104    24124      +20+ Misses       9335     9319      -16+ Partials     1402     1400       -2

Continue to review full report in Codecov by Sentry.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update893aab0...1e457e3. Read thecomment docs.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

I've noticed that K8s and apiserver contains several metrics that etcddoes not have. This PR adds the missing metrics to the defaultPrometheus registry.Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@fuweid
Copy link
Member

/retest

@k8s-ci-robot
Copy link

@tjungblu: The following testfailed, say/retest to rerun all failed tests or/retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
pull-etcd-coverage-report1e457e3linktrue/test pull-etcd-coverage-report

Full PR test history.Your PR dashboard. Please help us cut down on flakes bylinking to anopen issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository. I understand the commands that are listedhere.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tjungblu@k8s-ci-robot@fuweid
[8]ページ先頭
©2009-2025 Movatter.jp