NotificationsYou must be signed in to change notification settings
Fork7.8k
Star15.9k

fix(doc): Update link to lib.json in documentation#12153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

robertlipe wants to merge2 commits intoespressif:master

base:master

Choose a base branch

fromrobertlipe:patch-1

Open

fix(doc): Update link to lib.json in documentation#12153

robertlipe wants to merge2 commits intoespressif:masterfromrobertlipe:patch-1

+1 −1

Conversation

Copy link

robertlipe commentedDec 19, 2025

Fix broken Github link in released doc.

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
Please provide related links (eg. Issue which will be closed by this Pull Request)
Pleaseupdate relevant Documentation if applicable
Please checkContributing guide
Pleaseconfirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

Please describe your proposed Pull Request and it's impact.

Test Scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

Update link to lib.json in documentation

db40095

Fix broken Github link in released doc.

robertlipe requested a review frompedrominatel as acode owner

December 19, 2025 01:08

Copy link

CLAassistant commentedDec 19, 2025•
edited
Loading

All committers have signed the CLA.

Copy link

Contributor

github-actionsbot commentedDec 19, 2025•
edited
Loading

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message`"Fix link to lib.json in external_libraries_test.rst"`: summary looks empty type/action looks empty the commit message`"Update link to lib.json in documentation"`: summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: followConventional Commits style correct format of commit message should be:`<type/action>(<scope/component>): <summary>`, for example`fix(esp32): Fixed startup timeout issue` allowed types are:`change,ci,docs,feat,fix,refactor,remove,revert,test` sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) `TIP:` Install pre-commit hooks and run this check when committing (uses theConventional Precommit Linter).

👋Hello robertlipe, we appreciate your contribution to this project!

📘 Please review the project'sContributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you haveread and signed theContributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by thePR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with eachpush event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger isnot a substitute for human code reviews; it's still important to request a code review from your colleagues.
-Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manuallyretry these Danger checks, please navigate to theActions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫dangerJS against4fbf50e

robertlipe changed the title~~Update link to lib.json in documentation~~fix(doc): Update link to lib.json in documentation

Dec 19, 2025

pedrominatel reviewed

Dec 19, 2025

View reviewed changes

Copy link

Member

pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@robertlipe for catching this!
Please change it to the correct link.

docs/en/external_libraries_test.rst OutdatedShow resolvedHide resolved

Fix link to lib.json in external_libraries_test.rst

4fbf50e

Eithier works for me right now, but I just want it fixed, so OK.

pedrominatel approved these changes

Dec 19, 2025

View reviewed changes

pedrominatel requested a review fromme-no-dev

December 19, 2025 09:28

pedrominatel added the Status: Pending MergePull Request is ready to be merged label

Dec 19, 2025

Copy link

Author