Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Helper block for collision with group#320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
manuq wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromcollision-with-group-helper

Conversation

@manuq
Copy link
Contributor

This is a 3-in-1 helper block for the common pattern found in the demos. It replaces adding:

  • A "when this node collides with ..." block
  • An "if" block
  • An "is node in group" block

This is a 3-in-1 helper block for the common pattern found in the demos.It replaces adding:- A "when this node collides with ..." block- An "if" block- An "is node in group" block
@manuq
Copy link
ContributorAuthor

Draft for now because our signal handlers have the same "on_SIGNAL" name.

@urbit-pilled
Copy link
Contributor

urbit-pilled commentedDec 18, 2024
edited
Loading

Having two of these blocks will generate 2 functions with the same "_on_body_entered" callback, is this the problem you're talking about with the "on_SIGNAL" name?

If so, doesn't this problem already exist in the "when this node collides with .." block?

This will be a hard fix because you need a way to make the signal callback unique but we code the function name withcode_template so in order for it to be unique it needs to be dynamically generated.

@manuq
Copy link
ContributorAuthor

Having two of these blocks will generate 2 functions with the same "_on_body_entered" callback, is this the problem you're talking about with the "on_SIGNAL" name?

Yes, we need a better way. For example the Visual Shaders in Godot use suffixes (try creating a visual shader and then click "Show generated shader code". We'll need a solution like that.

urbit-pilled reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manuq@urbit-pilled

[8]ページ先頭

©2009-2025 Movatter.jp