Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge kabufuda#4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Antidote wants to merge85 commits intomain
base:main
Choose a base branch
Loading
frommerge-kabufuda
Draft

Merge kabufuda#4

Antidote wants to merge85 commits intomainfrommerge-kabufuda

Conversation

@Antidote
Copy link
Collaborator

First phase of merging kabufuda into aurora, this might be a bit messy so I'm doing this in a separate branch for the time being, I'm creating this PR for input as I go through the process of cleaning up and merging the two APIs more seamlessly.

Antidoteand others added30 commitsApril 19, 2025 19:53
# Conflicts:#CMakeLists.txt
Remove unrelated classes from Card.{cpp,hpp}
IconAddress makes no sense, points to the start of the banner, with the icon directly following,
jackoalanand others added29 commitsApril 19, 2025 19:53
Amends broken or missing doxygen parameters. While we're at it, we canexpand the documentation a little bit to be somewhat more explanatoryabout the functions.
Ensures all inclusions are made where necessary.
Same behavior, but with stronger typing. We can also eliminate usages ofmagic values in some places.
Previously this was zeroing out the maker array, which it shouldn't bedoing.
Anonymous structs have a limitation on GCC when involving non-trivialdefault constructors, as it's a compiler extension and not actuallystandard C++ to use anonymous structs. We can give the struct a concretename, which fixes this issue.
Same behavior, but ensures input absolutely satisfies the total amountof data that needs to be copied.
Makes conversions explicit in order to prevent error-prone implicitconversions.
This doesn't modify instance state, so it can be turned into a constmember function.
These don't modify member state, so they can be made const .
Maintains parity with hecl's version of the macro, etc.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Antidote@jackoalan@lioncash@encounter

[8]ページ先頭

©2009-2025 Movatter.jp