- Notifications
You must be signed in to change notification settings - Fork10
Merge kabufuda#4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Antidote wants to merge85 commits intomainChoose a base branch frommerge-kabufuda
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
# Conflicts:#CMakeLists.txt
Remove unrelated classes from Card.{cpp,hpp}IconAddress makes no sense, points to the start of the banner, with the icon directly following,
Amends broken or missing doxygen parameters. While we're at it, we canexpand the documentation a little bit to be somewhat more explanatoryabout the functions.
Ensures all inclusions are made where necessary.
Same behavior, but with stronger typing. We can also eliminate usages ofmagic values in some places.
Previously this was zeroing out the maker array, which it shouldn't bedoing.
This reverts commit698e37d.
Anonymous structs have a limitation on GCC when involving non-trivialdefault constructors, as it's a compiler extension and not actuallystandard C++ to use anonymous structs. We can give the struct a concretename, which fixes this issue.
Same behavior, but ensures input absolutely satisfies the total amountof data that needs to be copied.
Makes conversions explicit in order to prevent error-prone implicitconversions.
Avoids a sign conversion
This doesn't modify instance state, so it can be turned into a constmember function.
These don't modify member state, so they can be made const .
Maintains parity with hecl's version of the macro, etc.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First phase of merging kabufuda into aurora, this might be a bit messy so I'm doing this in a separate branch for the time being, I'm creating this PR for input as I go through the process of cleaning up and merging the two APIs more seamlessly.