- Notifications
You must be signed in to change notification settings - Fork425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add support for :keypress property to eventbox#1272
Open
AlexandrePicavet wants to merge1 commit intoelkowar:masterChoose a base branch fromAlexandrePicavet:feat/eventbox-keypress-command
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Add support for :keypress property to eventbox#1272
AlexandrePicavet wants to merge1 commit intoelkowar:masterfromAlexandrePicavet:feat/eventbox-keypress-command
+48 −1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3199825
toffc38fe
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wanted to be able to close my window by pressing the
Escape
key, but I couldn't figure out how to do that, so I added a way to handlekeypress
events on theeventbox
widget to execute a command.Usage
The
keypress
property is structured in the following way:Enter
: The key to press|>
: The separatorecho 'You pressed the Enter key'
: The commandHere's an example of how to use it:
Showcase
eww-keypress.mp4
Additional Notes
keypress
indicating which key has been pressed and which widget caught this event. Do you find this useful, or would you prefer that I remove it ?Checklist
docs/content/main
directory has been adjusted to reflect my changes.cargo fmt
to automatically format all code before committing.