- Notifications
You must be signed in to change notification settings - Fork810
[7.x][CI] Updates GitHub Actions#1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
picandocodigo wants to merge10 commits into7.xChoose a base branch
base:7.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cd57028 to2939703Compare748b3a6 to930d768CompareLock bundler to v 2.4.22, since Ruby old :(Removes unnecessary package installationUpdates STACK_VERSIONAdds jruby 9.4Run bundle install with BUNDLE_GEMFILEUpdates actions/checkoutsqlite for Rails 5 shenanigans
ActiveSupport patches Kernel to add `class_eval` but this behavior wasn'tloaded in the test environment. This created a discrepancy between testand prod, causing tests to fail that should have passed and vice versa.Fully loading ActiveSupport makes the test environment more accurate.
The goal of ClassMethodsProxy is to avoid polluting the target's namespace,but it was possible to do this by accident when calling `class_eval` beforeActiveSupport was completely loaded. This test ensures the namespace isn'tpolluted, regardless of the load state of ActiveSupport.
This PR switches the elasticsearch-rails gem to use a new signatureof the ActiveSupport::LogSubscriber#color method when called in anapp using Rails 7.1+. With older Rails, the gem uses the working, oldsignature.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.