- Notifications
You must be signed in to change notification settings - Fork16
Add PyObject.to_int() method returning i64#394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Add PyObject.to_int() method returning i64#394
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Add the py-to-int primitive that extracts a Python integer as i64,complementing the existing from_int method for bidirectional conversion.
codspeed-hqbot commentedDec 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#394 willnot alter performanceComparing Summary
|
saulshanabrook left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you! Could you add a little test for this in test_high_level?
Yeah the current set of primitives with py objects are rather arbitrary, would be good to fill them out more.
nelhage commentedDec 18, 2025
Done! Looks like the test failures are infra issues, at a glance. |
Add the py-to-int primitive that extracts a Python integer as i64, complementing the existing from_int method for bidirectional conversion.
Implemented using Claude Code, but reviewed by me before submission. I would find this useful for some current work, where I end up moving between the Python domain and the egglog domain fairly heavily.