Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork312
feat: add preliminary support for Bun#490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OnurGvnc commentedSep 10, 2023
I tried ❯ bun remove zodbun remove v1.0.0 (822a00c4)patch-package 8.0.0Applying patches...@remix-run/dev@1.19.3 ✔@remix-run/react@1.19.3 ✔ - zod 1 packages removed [38.00ms] |
Strengthless commentedSep 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This PR is now ready to merge, with only two caveats as mentioned in#490 (comment). @ds300 Can you please review this PR? :) |
robertherber commentedOct 16, 2023
Looking forward to this :) Been using pnpm for a while and been missing patch-package - so having it work with bun will be yummy! Hoping this will work in monorepos as well! |
lovlyx commentedJan 6, 2024
any news on this? |
rikur commentedJan 12, 2024
Wish I could use patch-package to patch patch-package with this patch 😂 I guess I just need to fork the repo. |
robertherber commentedJan 31, 2024
Until this is merged, would you consider publishing this fork on npm@Strengthless? |
erickreutz commentedFeb 7, 2024
LGTM! |
medv commentedFeb 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It's happening! Using this method for nowoven-sh/bun#2336 (comment) |
robertherber commentedMar 19, 2024
@ds300 I understand you probably have lots going on - but having this merged would be a key enabler! 🙏🙂 |
miblanchard commentedMar 21, 2024
@robertherber I am trying to use this method right now and published it under @miblanchard/patch-package@8.0.12 until this is merged and published. |
Uh oh!
There was an error while loading.Please reload this page.
Closes#489.
Changelogs:
--use-bunflag, similar to the current--use-yarnflag.parseBunLockfile.tsto convert bun.lockb into yarn v1 lockfiles.getPackageResolution.tsto handle bun conversions before parsing.detectPackageManager.tsto detect bun, bun workspaces and multiple lockfiles.Caveats:
Currently awaiting confirmation on how Bun handles postinstalls, for writing up the README about bun setup. (Willbun removeexecute postinstall scripts? If not, bun users should also installpostinstall-postinstalljust like yarn v1 users.)Temporary workaround (while this PR is unmerged):
pnpm patch/patch-packageoven-sh/bun#2336 (comment),