Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

SupportedRepositoryService.UpdateHook in GitLab driver.#73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chhsia0 wants to merge2 commits intodrone:master
base:master
Choose a base branch
Loading
fromchhsia0:updatehook-gitlab

Conversation

@chhsia0
Copy link
Contributor

@chhsia0chhsia0 commentedAug 21, 2020
edited
Loading

Note that the returned hook events are changed to reflect the actual parameter names used to create or update the webhook. Specifically, the originalconvertEvents in the GitLab driver sets the value ofHook.Events with the
following mapping:

issues_events=true -> "issue"tag_push_events=true -> "tag"push_events=true -> "push"note_events=true -> "comment"merge_requests_events=true -> "merge"other options -> none

It seems the event name strings are arbitrary and not consistent across different drivers, so the mapping itself doesn't provide much abstraction (if any). More importantly, for all other drivers,Hook.Events contains native events unrecognized by go-scm, but GitLab driver completely discards them. This is important to implement logics to "reconcile" webhooks (i.e., update only if configuration has changed) to sync the list of watched events. Therefore, this patch proposesHook.Events returned by the hook-related functions in the GitLab driver to store the option names if their values are true, e.g.,["issues_events", "push_events", "confidential_issues_events"].

This is a breaking change.

Note that the returned hook events are changed to reflect the actual parameternames used to create or update the webhook. Specifically, the original`convertEvents` in the GitLab driver sets the value of `Hook.Events` with thefollowing mapping:```issues_events=true -> "issue"tag_push_events=true -> "tag"push_events=true -> "push"note_events=true -> "comment"merge_requests_events=true -> "merge"other options -> none```It seems the event name strings are arbitrary and not consistent acrossdifferent drivers, so the mapping itself doesn't provide much abstraction (ifany). More importantly, for all other drivers, `Hook.Events` contains nativeevents unrecognized by go-scm, but GitLab driver completely discards them. Thisis important to implement logics to "reconcile" webhooks (i.e., update only ifneeded) to sync the list of watched events. Therefore, this patch proposes`Hook.Events` returned by the hook-related functions in the GitLab driver tostore the option names if their values are true, e.g., `["issues_events","push_events", "confidential_issues_events"]`.This is a breaking change.
@chhsia0chhsia0 changed the titleSupportedRepositoryService.UpdatedHook in GitLab driver.SupportedRepositoryService.UpdateHook in GitLab driver.Aug 22, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.


chhsia0 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let usrecheck it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bradrydzewskibradrydzewskiAwaiting requested review from bradrydzewski

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chhsia0@CLAassistant@bradrydzewski

[8]ページ先頭

©2009-2025 Movatter.jp