- Notifications
You must be signed in to change notification settings - Fork259
SupportedRepositoryService.UpdateHook in GitLab driver.#73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
chhsia0 wants to merge2 commits intodrone:masterChoose a base branch fromchhsia0:updatehook-gitlab
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Note that the returned hook events are changed to reflect the actual parameternames used to create or update the webhook. Specifically, the original`convertEvents` in the GitLab driver sets the value of `Hook.Events` with thefollowing mapping:```issues_events=true -> "issue"tag_push_events=true -> "tag"push_events=true -> "push"note_events=true -> "comment"merge_requests_events=true -> "merge"other options -> none```It seems the event name strings are arbitrary and not consistent acrossdifferent drivers, so the mapping itself doesn't provide much abstraction (ifany). More importantly, for all other drivers, `Hook.Events` contains nativeevents unrecognized by go-scm, but GitLab driver completely discards them. Thisis important to implement logics to "reconcile" webhooks (i.e., update only ifneeded) to sync the list of watched events. Therefore, this patch proposes`Hook.Events` returned by the hook-related functions in the GitLab driver tostore the option names if their values are true, e.g., `["issues_events","push_events", "confidential_issues_events"]`.This is a breaking change.
RepositoryService.UpdatedHook in GitLab driver.RepositoryService.UpdateHook in GitLab driver.Uh oh!
There was an error while loading.Please reload this page.
CLAassistant commentedJun 10, 2021
chhsia0 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, pleaseadd the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let usrecheck it. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Note that the returned hook events are changed to reflect the actual parameter names used to create or update the webhook. Specifically, the original
convertEventsin the GitLab driver sets the value ofHook.Eventswith thefollowing mapping:
It seems the event name strings are arbitrary and not consistent across different drivers, so the mapping itself doesn't provide much abstraction (if any). More importantly, for all other drivers,
Hook.Eventscontains native events unrecognized by go-scm, but GitLab driver completely discards them. This is important to implement logics to "reconcile" webhooks (i.e., update only if configuration has changed) to sync the list of watched events. Therefore, this patch proposesHook.Eventsreturned by the hook-related functions in the GitLab driver to store the option names if their values are true, e.g.,["issues_events", "push_events", "confidential_issues_events"].This is a breaking change.