- Notifications
You must be signed in to change notification settings - Fork259
add support for github pull request comment webhook parsing#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedJul 4, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
| returnnil,err | ||
| } | ||
| dst:=convertPullRequestReviewCommentHook(src) | ||
| returndst,nil |
bradrydzewskiJul 9, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe this function should set the action to one ofscm.ActionCreate,scm.ActionUpdate,scm.ActionDelete
| } | ||
| } | ||
| funcconvertPullRequestReviewCommentHook(src*pullRequestReviewCommentHook)*scm.PullRequestCommentHook { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe this should return aReviewCommentHook. The distinction is that a pull request comment is when you comment on the issue (although github treats pull requests the same as issues, other providers do not, so we abstract). The review comment is when you comment on code. TheReviewCommentHook also stores aReview information such as file name and line number.
fix: avoid failures on bitbucket cluster
Is this going stale? I'm currently using go-github to parse issue comments for pull requests but considering to add such support for go-scm. Is the intention of this PR to support review comment or issue comments on pull requests? Should I wait for this PR? Thanks for an update :) |
No description provided.