Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: escaping to git ref in path not working#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chamhaw wants to merge1 commit intodrone:master
base:master
Choose a base branch
Loading
fromchamhaw:master

Conversation

@chamhaw
Copy link

@chamhawchamhaw commentedFeb 8, 2023
edited
Loading

It seems an inadvertent mistake for escaping.

@bradrydzewski
Copy link
Contributor

Great catch. I feel like there may be one more bug fix needed. Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly. I'm not sure if / how this would manifest into a bug, but it would be great to do some more research on this and maybe get some unit tests for the different scenarios. cc@d1wilko@tphoney

@chamhaw
Copy link
Author

chamhaw commentedApr 7, 2023
edited
Loading

Can this bug be fixed?
@bradrydzewski@d1wilko@tboerger

@bradrydzewski
Copy link
Contributor

bradrydzewski commentedApr 7, 2023
edited
Loading

@chamhaw this needs to be addressed before we can get this merged

Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly

I think it is a simple order of operations issue. trim before you encode and that probably resolves the comment.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chamhaw@bradrydzewski

[8]ページ先頭

©2009-2025 Movatter.jp