- Notifications
You must be signed in to change notification settings - Fork259
fix: escaping to git ref in path not working#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
Great catch. I feel like there may be one more bug fix needed. Once we properly escape the reference it would prevent the subsequent scm.TrimRef call from working properly. I'm not sure if / how this would manifest into a bug, but it would be great to do some more research on this and maybe get some unit tests for the different scenarios. cc@d1wilko@tphoney |
chamhaw commentedApr 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can this bug be fixed? |
bradrydzewski commentedApr 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@chamhaw this needs to be addressed before we can get this merged
I think it is a simple order of operations issue. trim before you encode and that probably resolves the comment. |
Uh oh!
There was an error while loading.Please reload this page.
It seems an inadvertent mistake for escaping.