Commit22d9f76

chhsia0

committed

Set secret token inCreateHook only if non-empty.

1 parentfdc0060 commit22d9f76Copy full SHA for 22d9f76

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,11 @@ func (s *repositoryService) ListStatus(ctx context.Context, repo, ref string, op`
`114`	`114`	`func (srepositoryService)CreateHook(ctx context.Context,repostring,inputscm.HookInput) (scm.Hook,scm.Response,error) {`
`115`	`115`	`params:= url.Values{}`
`116`	`116`	`params.Set("url",input.Target)`
`117`		`-params.Set("token",input.Secret)`
	`117`	`+// Earlier versions of gitlab returned an error if the token was an empty string, so we only set`
	`118`	`+// the token value if non-empty.`
	`119`	`+ifinput.Secret!="" {`
	`120`	`+params.Set("token",input.Secret)`
	`121`	`+}`
`118`	`122`	`params.Set("enable_ssl_verification",strconv.FormatBool(!input.SkipVerify))`
`119`	`123`	`fork,v:=rangeconvertFromHookEvents(input.Events) {`
`120`	`124`	`params.Set(k,strconv.FormatBool(v))`

Comments

(0)