- Notifications
You must be signed in to change notification settings - Fork30
DOC: warn about --force for dirty repos#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
asmeurer commentedAug 2, 2020
doctr deploy --force should basically never be used. It forces doctr to run locally, whereas it normally only runs in Travis. It's only useful for development. We should probably hide the flag. doctr deploy stashes your dirty changes. It should unstash them, but maybe that failed. You can try running |
stsievert commentedAug 2, 2020
Luckily I've been able to recover. |
| parser.error("doctr does not appear to be running on Travis. Use " | ||
| "doctr deploy <target-dir> --force to run anyway.") | ||
| "doctr deploy <target-dir> --force to run anyway.\n\n" | ||
| "WARNING: this will remove any dirty files" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How about just not mentioning--force at all and also hiding it from the --help output.
What does this PR implement?
It warns about running
doctr deploywith the--forceflag and dirty files.I made the mistake of doing this, and this warning would have prevented my mistake. I am submitting this PR to ask a question: how do I recover those dirty files untracked by Git? Or are they gone forever?