- Notifications
You must be signed in to change notification settings - Fork123
Feature: Unit testing#42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ayshiff wants to merge4 commits intodraftbit:masterChoose a base branch fromayshiff:feature/unit-testing
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I felt thatavatar-generator needed some testing.
This PR setup the testing environment using
bs-jest/bs-react-testing-libraryand add some tests here and there.It's not much, but it's always better to have some tests.
Testing a ReasonReact component
bs-react-testing-library + bs-jest
I created a wrapper component called
TestIdwhich pass the data-testid (used byreact-testing-library) props to its children.As Reasondoesn’t support using props with dashes.
I don't really like this method as it requires addingextra code to the source files, but it works.
1 - Wrap your component using the
TestIdWrapper inside your source file2 - Render your component inside your test file
3 - You can query your elements using your
data-testidor using other queries (queryByLabelText,queryByTitle,queryByText...) andfire some events.Testing a Reason function
bs-jest
NOTE: I had to add a
babel.config.jsfile and atransformIgnorePatternsoptions in thejestconfiguration because of the es6 modules (related issue).I also had to add the preset
babel-preset-gatsbybecause gatsby returned an error during the compilation if I did not specify it.