This repository was archived by the owner on Nov 17, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork10.2k
Veysel MUTLU changes#1756
Open
vmutlu wants to merge7 commits intodotnet-architecture:devChoose a base branch
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Veysel MUTLU changes#1756
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… the field where services are registered in the startup.cs class.
…frastructure project were gathered here by creating a base class.
…pplicable to the whole project
…sent in API requests.
Marusyk suggested changesJun 7, 2022
| { | ||
| item.FillProductUrl(baseUri,azureStorageEnabled:azureStorageEnabled); | ||
| } | ||
| items.ForEach(item=>{item.FillProductUrl(baseUri,azureStorageEnabled:azureStorageEnabled);}); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is the point of the change?
| item.PictureUri=azureStorageEnabled | ||
| ?picBaseUrl+item.PictureFileName | ||
| :picBaseUrl.Replace("[0]",item.Id.ToString()); | ||
| // https://www.linkedin.com/feed/update/urn:li:activity:6841055191211491328/ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we really need this link to the Linkedin post here? It didn't answer the question what is better to use
| _userManager=userManager; | ||
| } | ||
| //New Method ArgumentNullException.ThrowIfNull (obj) Added to .NET 6 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm sure this source code is not a guide for C# new features, it is more about architecture.
Why do we need to include links to posts? Why not official documentation then?
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Changes
Some abbreviations and class additions were made to the project.