- Notifications
You must be signed in to change notification settings - Fork1.2k
Add RazorLangVersion 11#52226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Add RazorLangVersion 11#52226
Conversation
Thanks for your PR, @@davidwengier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request overview
This PR adds support for RazorLangVersion 11.0 for .NET 11.0 by introducing a new version-specific configuration block in the Razor SDK targets file.
Key Changes:
- Adds a new
<When>condition block for .NETCoreApp 11.0+ that sets RazorLangVersion to 11.0 - Sets all necessary version flags (_TargetingNET110OrLater and earlier version flags)
- Enables UseRazorSourceGenerator and _RazorUseRoslynTokenizer features for the new version
davidwengier commentedDec 16, 2025
Are these sorts of PRs better done in the VMR these days, so we can be sure things are inserted in the right places/order first? |
| <_TargetingNET100OrLater>true</_TargetingNET100OrLater> | ||
| <UseRazorSourceGeneratorCondition="'$(Language)' == 'C#' AND '$(UseRazorSourceGenerator)' == ''">true</UseRazorSourceGenerator> | ||
| <RazorLangVersionCondition="'$(RazorLangVersion)' == ''">9.0</RazorLangVersion> | ||
| <RazorLangVersionCondition="'$(RazorLangVersion)' == ''">10.0</RazorLangVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Discussed with the team and we're going to backport this to 10.0.2xx too
davidwengier commentedDec 17, 2025
That answers my question: Need to wait for Razor to flow in here, via VMR, before this can be merged. Hopefully that is all in place to succeed in time... |
No description provided.