Context

Our code runs the MQTT Client in a Background Service.

Problem

Providing any CancellationToken to any of those methods -ConnectAsync,PingAsync,DisconnectAsync,SubscribeAsync, andUnsubscribeAsync disregards theTimeout option.

In Background Services, we always provide the cancellation token, so if we are not aware of this behaviour, those methods will never timeout, disregarding theWithTimeout orTimeout completely.
I do acknowledge this is partially mentioned in the Sample for timeouts, though, and it is recommended to use a linked token source.

I found it confusing, so I'm suggesting a change.

Solution

Instead of disregarding the Timeout, those operations should always consider it and link the cancellation sources.

I'm also aware this is a breaking change, as it'd cause Timeouts for existing code that depends on overwriting this with a linked token with an expiry.

Thank you for considering this contribution. I appreciate any feedback or suggestions for change. Alternatively, we could consider improving the sample and/or documentation.