This repository was archived by the owner on Mar 11, 2021. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork159
[WIP] Handle expanded character range slugs better#426
Draft
reefdog wants to merge9 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
`URI.parse` chokes on CGI-unescaped unicode chars. `Addressable::URI.parse` doesn't. We're already using Addressable downstream, so just promote it to first-class required gem and use it.
This smells bad and I would like to rethink it.
# Conflicts:#Gemfile#Gemfile.lock
# Conflicts:#app/controllers/api_controller.rb#test/controllers/oembed_controller_test.rb#test/lib/statistics_test.rb
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full description coming. Meanwhile see#315.