Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
feat: The timing of thedoneEach hook call for the cover#2427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
YiiGuxing wants to merge13 commits intodocsifyjs:developChoose a base branch fromYiiGuxing:feat-cover-lifecycle
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes fromall commits
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
bd5f879 feat: The timing of the `doneEach` hook call for the cover
YiiGuxingbcd1090 Merge branch 'develop' into feat-cover-lifecycle
jhildenbiddle117eb08 Merge branch 'develop' into feat-cover-lifecycle
jhildenbiddlef7666ca Merge branch 'develop' into feat-cover-lifecycle
YiiGuxingdea1229 test: Add test cases for the `doneEach` hook
YiiGuxing56c922f style: Fix eslint code style
YiiGuxingb2a9c06 Merge branch 'develop' into feat-cover-lifecycle
Koooooo-7a3c3359 Merge branch 'develop' into feat-cover-lifecycle
sy-records837d04a fix(test): fix HTML logging
YiiGuxingec48f93 feat(test): add dynamic and asynchronous content provision support fo…
YiiGuxing7cc7cdf feat: cover page supports embedding external files
YiiGuxing0333d96 test: disable logging
YiiGuxinge796604 Merge branch 'develop' into feat-cover-lifecycle
jhildenbiddleFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
37 changes: 23 additions & 14 deletionssrc/core/fetch/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
57 changes: 38 additions & 19 deletionssrc/core/render/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletionstest/e2e/embed-files.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import docsifyInit from '../helpers/docsify-init.js'; | ||
| import { test, expect } from './fixtures/docsify-init-fixture.js'; | ||
| test.describe('Embed files', () => { | ||
| const routes = { | ||
| 'fragment.md': '## Fragment', | ||
| }; | ||
| test('embed into homepage', async ({ page }) => { | ||
| await docsifyInit({ | ||
| routes, | ||
| markdown: { | ||
| homepage: "# Hello World\n\n[fragment](fragment.md ':include')", | ||
| }, | ||
| // _logHTML: {}, | ||
| }); | ||
| await expect(page.locator('#main')).toContainText('Fragment'); | ||
| }); | ||
| test('embed into cover', async ({ page }) => { | ||
| await docsifyInit({ | ||
| routes, | ||
| markdown: { | ||
| homepage: '# Hello World', | ||
| coverpage: "# Cover\n\n[fragment](fragment.md ':include')", | ||
| }, | ||
| // _logHTML: {}, | ||
| }); | ||
| await expect(page.locator('.cover-main')).toContainText('Fragment'); | ||
| }); | ||
| }); |
68 changes: 68 additions & 0 deletionstest/e2e/plugins.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
60 changes: 30 additions & 30 deletionstest/helpers/docsify-init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.