Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: files from basePath should be remoteUrl:false#1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
b6pzeusbc54tvhw5jgpyw8pwz2x6gs wants to merge1 commit intodocsifyjs:develop
base:develop
Choose a base branch
Loading
fromb6pzeusbc54tvhw5jgpyw8pwz2x6gs:1659-fix-problem-script-not-running-when-using-basePath

Conversation

@b6pzeusbc54tvhw5jgpyw8pwz2x6gs
Copy link

@b6pzeusbc54tvhw5jgpyw8pwz2x6gsb6pzeusbc54tvhw5jgpyw8pwz2x6gs commentedNov 3, 2021
edited
Loading

Summary

When using thebasePath as an absolute url including the domain and the domain ofindex.html and the domain ofbasePath are different, Currently, files fetched frombasePath are treated asisExternal: true , and I think this behavior is a bug.

basePath is a value that can be entered only with the authority of the document site administrator, and thebasePath server can also be considered owned by the administrator, so theisRemoteUrl value should befalse.

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#1659

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercelbot commentedNov 3, 2021
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/9PEsj4Y74qkJAhpihAttVtDSSv1y
✅ Preview:https://docsify-preview-git-fork-b6pzeusbc54tvhw5jg-bd121d-docsify-core.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commit16b5ba5:

SandboxSource
docsify-templateConfiguration

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@b6pzeusbc54tvhw5jgpyw8pwz2x6gs

[8]ページ先頭

©2009-2025 Movatter.jp