Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.8k
fix: files from basePath should be remoteUrl:false#1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vercelbot commentedNov 3, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect:https://vercel.com/docsify-core/docsify-preview/9PEsj4Y74qkJAhpihAttVtDSSv1y |
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit16b5ba5:
|
Uh oh!
There was an error while loading.Please reload this page.
Summary
When using the
basePathas an absolute url including the domain and the domain ofindex.htmland the domain ofbasePathare different, Currently, files fetched frombasePathare treated asisExternal: true, and I think this behavior is a bug.basePathis a value that can be entered only with the authority of the document site administrator, and thebasePathserver can also be considered owned by the administrator, so theisRemoteUrlvalue should befalse.What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
#1659
Tested in the following browsers: