Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
Allow list_model_info with to target multiple --models from the commandline#1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cb109 wants to merge1 commit intodjango-extensions:mainChoose a base branch fromcb109:list_model_info/target-multiple-models-with-cli-option
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It can then be used like: python manage.py list_info_model --models app1.Model1,app2.Model2Since Django's management commands use argparse with a forgiving CLIoption config, the old --model option will still work the exact sameway as before (as it will match to the new --models), thus the change isbackwards compatible.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I wanted to output the
list_model_infofor some of our models (we have hundreds), but currently can a) either outputall of them or b) call the commandonce per--model. I found that non-intuitive and would much prefer to be able to specify the desired models in a single command.This PR changes
list_model_info --model app.Modeltolist_model_info --models app1.Model1,app2.Model2,app3.Model3.Since Django's management commands useargparse with a forgiving CLI option config, the old
--modeloption will still work the exact same way as before (as it will match to the new --models), thus the change is backwards compatible.Maybe it's worth thinking about something like this? The API could be different (e.g. support using
--modelmore than once, orhandle multiple arguments, or a separate option).