Commit8b9d5f4

committed

fix(GeneratedField): Require db_persist argument in the signature.

1 parent30e0a43 commit8b9d5f4Copy full SHA for 8b9d5f4

File tree

-6

lines changed

-6

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -478,6 +478,7 @@ answer newbie questions, and generally made Django that much better:`
`478`	`478`	`Jarek Głowacki <jarekwg@gmail.com>`
`479`	`479`	`Jarek Zgoda <jarek.zgoda@gmail.com>`
`480`	`480`	`Jarosław Wygoda <jaroslaw@wygoda.me>`
	`481`	`+ Jason Cameron <https://jasoncameron.dev>`
`481`	`482`	`Jason Davies (Esaj) <https://www.jasondavies.com/>`
`482`	`483`	`Jason Huggins <http://www.jrandolph.com/blog/>`
`483`	`484`	`Jason McBrayer <http://www.carcosa.net/jason/>`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ class GeneratedField(Field):`
`15`	`15`	`_query=None`
`16`	`16`	`output_field=None`
`17`	`17`
`18`		`-def__init__(self,,expression,output_field,db_persist=None,*kwargs):`
	`18`	`+def__init__(self,,expression,output_field,db_persist,*kwargs):`
`19`	`19`	`ifkwargs.setdefault("editable",False):`
`20`	`20`	`raiseValueError("GeneratedField cannot be editable.")`
`21`	`21`	`ifnotkwargs.setdefault("blank",True):`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1278,7 +1278,7 @@ when :attr:`~django.forms.Field.localize` is ``False`` or
`1278`	`1278`	``GeneratedField``
`1279`	`1279`	`------------------`
`1280`	`1280`
`1281`		`-.. class:: GeneratedField(expression, output_field, db_persist=None, **kwargs)`
	`1281`	`+.. class:: GeneratedField(expression, output_field, db_persist, **kwargs)`
`1282`	`1282`
`1283`	`1283`	`A field that is always computed based on other fields in the model. This field`
`1284`	`1284`	is managed and updated by the database itself. Uses the ``GENERATED ALWAYS``

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,10 +95,6 @@ def test_database_default_unsupported(self):`
`95`	`95`
`96`	`96`	`deftest_db_persist_required(self):`
`97`	`97`	`msg="GeneratedField.db_persist must be True or False."`
`98`		`-withself.assertRaisesMessage(ValueError,msg):`
`99`		`-GeneratedField(`
`100`		`-expression=Lower("name"),output_field=CharField(max_length=255)`
`101`		`- )`
`102`	`98`	`withself.assertRaisesMessage(ValueError,msg):`
`103`	`99`	`GeneratedField(`
`104`	`100`	`expression=Lower("name"),`

Comments

(0)