NotificationsYou must be signed in to change notification settings
Fork4k
Star26.4k

fix: Remove data conditional check#11250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Jiralite wants to merge1 commit intomain

base:main

Choose a base branch

fromfix/data-removal

Open

fix: Remove data conditional check#11250

Jiralite wants to merge1 commit intomainfromfix/data-removal

+5 −5

Conversation

Copy link

Member

Jiralite commentedNov 5, 2025

These should never be constructed without data...

The blame seems to go years and years back. Was likely ancient logic made redundant over time.

fix: remove conditional

7e5accf

Jiralite requested a review froma team as acode owner

November 5, 2025 18:08

Jiralite requested review fromSpaceEEC,iCrawl,kyranet andvladfrangu

November 5, 2025 18:08

github-project-automationbot added this todiscord.js

Nov 5, 2025

github-project-automationbot moved this toTodo indiscord.js

Nov 5, 2025

Copy link

vercelbot commentedNov 5, 2025

The latest updates on your projects. Learn more aboutVercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
discord-js	Ignored			Nov 5, 2025 6:08pm
discord-js-guide	Ignored			Nov 5, 2025 6:08pm

github-actionsbot added the packages:discord.js label

Nov 5, 2025

Jiralite added semver:patch packages:discord.js labels

Nov 5, 2025

Jiralite added this to thediscord.js 15.0.0 milestone

Nov 5, 2025

Jiralite added the backport-candidate label

Nov 5, 2025

iCrawl requested a review fromCopilot

November 5, 2025 18:19

CopilotAI reviewed

Nov 5, 2025

View reviewed changes

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR removes the conditionalif (data) checks before calling_patch(data) in the constructors of multiple structures includingWebhook,ThreadChannel,Role,PermissionOverwrites, andGuildMember. The changes standardize the initialization pattern by always calling_patch regardless of whether data is provided.

Removes conditional data checks before_patch() calls in constructors
Affects 5 structure classes: Webhook, ThreadChannel, Role, PermissionOverwrites, and GuildMember

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
packages/discord.js/src/structures/Webhook.js	Removes`if (data)` check before calling`_patch(data)` in constructor
packages/discord.js/src/structures/ThreadChannel.js	Removes`if (data)` check before calling`_patch(data)` in constructor
packages/discord.js/src/structures/Role.js	Removes`if (data)` check before calling`_patch(data)` in constructor
packages/discord.js/src/structures/PermissionOverwrites.js	Removes`if (data)` check before calling`_patch(data)` in constructor
packages/discord.js/src/structures/GuildMember.js	Removes`if (data)` check before calling`_patch(data)` in constructor

Comments suppressed due to low confidence (1)

packages/discord.js/src/structures/ThreadChannel.js:43

The constructor accessesdata.owner_id directly on line 43 before calling_patch. With the removedif (data) check, ifdata is null or undefined, this will throw a TypeError. The same issue exists on line 36 withdata.guild_id. Either restore the conditional check or add null/undefined handling in the constructor.