Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4k
fix(Client): Move client initialization code#11184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
vercelbot commentedOct 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The latest updates on your projects. Learn more aboutVercel for GitHub. 2 Skipped Deployments
|
Uh oh!
There was an error while loading.Please reload this page.
Qjuh commentedOct 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'd say the better fix would be to move all the READY event handling into READY.js, not the other way around. Or at least the checkReady() call |
I just noticed that the Ready event is async |
I believe this was not added to READY.js on purpose because the handler is async |
Qjuh commentedOct 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Since I was the one who wrote that I can assure you that's not the reason. In v14 the checkReady check is in READY.js; this was simply an oversight when adapting to the direct use of /ws and should be reverted to check in READY.js adding await would be a good idea however, and then the checkReady check for READY event could be added to handlePacket instead. Similar to how it checks for GUILD_CREATE and _DELETE. |
Then checkReady() was not async |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
before merging, we should give this a little test.
@Jiralite would you mind? otherwise, I can get to it tonightdiscord.js@15.0.0-move-client-init.1761650119-a4c0a246f
was a little later than "tonight", but I got to it. we should be good :) |
Uh oh!
There was an error while loading.Please reload this page.
Please describe the changes this PR makes and why it should be merged:
Closes#11180
Status and versioning classification: