- Notifications
You must be signed in to change notification settings - Fork3
Ramen merge attempt #1 (Print subvolume path alongside subvolume ID)#3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Ramen-LadyHKG wants to merge13 commits intodim-geo:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add new files to Testing branch
Add Previews_3-check.mp4
Video and WebP
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for your project! I've found it extremely useful for checking the real size usage of each btrfs subvolume/snapshot. However, while using the latest version, I noticed a few areas where the user experience could be improved.
In particular, the script currently displays subvolume IDs without any clear reference to what each ID represents. This forces users to repeatedly run sudo btrfs subvolume list / to match IDs with their paths, which can be quite inconvenient.
https://github.com/Ramen-LadyHKG/btrfs-subvolume-size-diff-forked
To address this, I’ve added a feature to print the btrfs subvolume path alongside its ID directly within the script, making it easier to identify each subvolume or snapshot.
Additionally, I’ve made some minor changes, including switching to README_HK.md and fixing some typos.
My intention is not to replace your original work, but to contribute back by merging these improvements into your repository. I believe this enhancement would benefit the broader community of users.
Looking forward to your feedback!
Best regards,
Ramen-LadyHKG