- Notifications
You must be signed in to change notification settings - Fork442
Pub sub "reloaded" --> new version of the pub-sub app#1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
552020 wants to merge7 commits intodfinity:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Replace Counter type with NewsMessage type for better real-world representation- Rename subscriber functions for clarity (init -> subscribeToTopic)- Update state tracking from count to totalReadingTime- Adjust callback functions to handle NewsMessage type"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested it, it seems to work.
Overview
Why do we need this feature? What are we trying to accomplish?
While working on the2.2 of the "Motoko Developer Liftoff" I had some hard time to understand the example app. The course was pretty good till to this point. So I tried to rewrite the example in a more understandable way, without making too complicate, and also adding some documentation in the README to understand the PubSub app. Since the PubSub app is tied to the video, probably it doesn't make sense to replace them. But maybe this version could be added as a note at the end of the lesson.
An explanation of the changes are in the README itself.
Requirements
What requirements are necessary to consider this problem solved?
Considered Solutions
What solutions were considered?
Recommended Solution
What solution are you recommending? Why?
Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?