Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Fix problems related to use terser nameCache#966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
zyrong wants to merge2 commits intodevelopit:master
base:master
Choose a base branch
Loading
fromzyrong:fix/terser-nameCache

Conversation

zyrong
Copy link
Contributor

@zyrongzyrong commentedMay 20, 2022
edited
Loading

  1. The nameCache obtained in writebundle hook is not a reference to terseroptions
  2. JSON.stringify(nameCache) requires converting regex to a string first.

This commit fixes the problems related to terser namecache. When terser compresses the code, the damaged variable names will be written to the namecache. Finally, the namecache will be written to the file system inthis code, but after my test, it doesn't seem to work here

1. The nameCache obtained in writebundle hook is not a reference to terseroptions2. JSON.stringify(nameCache) requires converting regex to a string first.
@changeset-bot
Copy link

changeset-botbot commentedMay 20, 2022
edited
Loading

🦋 Changeset detected

Latest commit:685962d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
microbundleMinor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rschristianrschristian mentioned this pull requestJun 3, 2022
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rschristianrschristianrschristian left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@zyrong@rschristian

[8]ページ先頭

©2009-2025 Movatter.jp